-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rules_go and buildtools #956
Update to rules_go and buildtools #956
Conversation
This fixes the build with Bazel 0.27.
Fixes #955 presumably |
I noticed that the WORKSPACE contains references to the old Gopkg.toml. Since the switch to vgo, the dependencies versions used in the Golang and Bazel builds are different. We could consider using:
to autogenerate the WORKSPACE to match go.mod, but let's focus on the current problem for now. |
@drigz I would like that please. Could you open a separate PR with that change? |
This is also required for Bazel 0.27, it seems.
Not yet :/ |
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
=======================================
Coverage 53.23% 53.23%
=======================================
Files 40 40
Lines 3999 3999
=======================================
Hits 2129 2129
Misses 1672 1672
Partials 198 198 Continue to review full report at Codecov.
|
@johanbrandhorst PTAL, CI is green now. |
This would still be nice if you've got spare cycles! |
* Update to rules_go v0.18.6 This fixes the build with Bazel 0.27. * Update bazelbuild/buildtools to v0.26. This is also required for Bazel 0.27, it seems. Fixes grpc-ecosystem#955
This fixes the build with Bazel 0.27. Fixes #955.