Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rules_go and buildtools #956

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

drigz
Copy link
Contributor

@drigz drigz commented Jun 18, 2019

This fixes the build with Bazel 0.27. Fixes #955.

This fixes the build with Bazel 0.27.
@johanbrandhorst
Copy link
Collaborator

Fixes #955 presumably

@drigz
Copy link
Contributor Author

drigz commented Jun 18, 2019

I noticed that the WORKSPACE contains references to the old Gopkg.toml. Since the switch to vgo, the dependencies versions used in the Golang and Bazel builds are different. We could consider using:

bazel run //:gazelle -- update-repos -from_file=go.mod

to autogenerate the WORKSPACE to match go.mod, but let's focus on the current problem for now.

@johanbrandhorst
Copy link
Collaborator

@drigz I would like that please. Could you open a separate PR with that change?

This is also required for Bazel 0.27, it seems.
@drigz
Copy link
Contributor Author

drigz commented Jun 18, 2019

Fixes #955 presumably

Not yet :/

@codecov-io
Copy link

Codecov Report

Merging #956 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   53.23%   53.23%           
=======================================
  Files          40       40           
  Lines        3999     3999           
=======================================
  Hits         2129     2129           
  Misses       1672     1672           
  Partials      198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0c8ef...ff94f69. Read the comment docs.

@drigz drigz changed the title Update to rules_go v0.18.6 Update to rules_go and buildtools Jun 18, 2019
@drigz
Copy link
Contributor Author

drigz commented Jun 18, 2019

@johanbrandhorst PTAL, CI is green now.

@johanbrandhorst johanbrandhorst merged commit 883b764 into grpc-ecosystem:master Jun 18, 2019
@johanbrandhorst
Copy link
Collaborator

I noticed that the WORKSPACE contains references to the old Gopkg.toml. Since the switch to vgo, the dependencies versions used in the Golang and Bazel builds are different. We could consider using:

bazel run //:gazelle -- update-repos -from_file=go.mod

to autogenerate the WORKSPACE to match go.mod, but let's focus on the current problem for now.

This would still be nice if you've got spare cycles!

adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
* Update to rules_go v0.18.6

This fixes the build with Bazel 0.27.

* Update bazelbuild/buildtools to v0.26.

This is also required for Bazel 0.27, it seems.

Fixes grpc-ecosystem#955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel files are out of date
4 participants