Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option for the decoder - to disallow unknown fields #959

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Add new option for the decoder - to disallow unknown fields #959

merged 1 commit into from
Jun 21, 2019

Conversation

vsaveliev
Copy link
Contributor

@vsaveliev vsaveliev commented Jun 21, 2019

Hi, gRPC Gateway's Team.

It's a copy of #948.

@johanbrandhorst
Copy link
Collaborator

Could you please rebase on master to fix the bazel error?

@codecov-io
Copy link

Codecov Report

Merging #959 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   53.23%   53.26%   +0.02%     
==========================================
  Files          40       40              
  Lines        3999     4001       +2     
==========================================
+ Hits         2129     2131       +2     
  Misses       1672     1672              
  Partials      198      198
Impacted Files Coverage Δ
runtime/marshal_jsonpb.go 68.99% <100%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883b764...6a656d9. Read the comment docs.

@vsaveliev
Copy link
Contributor Author

done.

@johanbrandhorst johanbrandhorst merged commit d6fec18 into grpc-ecosystem:master Jun 21, 2019
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@vsaveliev
Copy link
Contributor Author

Thank you for the review and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants