-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camel case backward compatible in Swagger doc #988
Camel case backward compatible in Swagger doc #988
Conversation
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
==========================================
+ Coverage 53.43% 53.45% +0.01%
==========================================
Files 40 40
Lines 4027 4028 +1
==========================================
+ Hits 2152 2153 +1
Misses 1676 1676
Partials 199 199
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these new tests cover the case that caused an index out of range error too?
@johanbrandhorst , yes, it covered the test case ( |
Thanks for your contribution! |
Thank you so much @johanbrandhorst ! |
* Avoid potential out of range and support the convention that could be inside * Add some test cases for testing backward compatible
Hi @johanbrandhorst,
In the PR, #985, the snake case arguments will be converted to lower camel case when the
json_names_for_fields
is enabled.Now, I noticed that there is a backward compatible use case may need to support, which is
/
could be inside{}
, for example,"/{user.name=prefix/*}:customMethod"
. (Sorry I did not notice that)Also, when calculating
jsonSnakeCaseName
, if the name includes/
, then it could causeout of range
potentially. So, fixed it too.Sorry for about.