Skip to content

Conversation

@numanelahi
Copy link
Contributor

The response_to_json_translator currently supports streaming the messages as JSON array or as new line delimited. This PR adds support for enforcing Server-Sent Events (SSE) message framing (data: <message>\n\n) for streamed messages.

@google-oss-prow
Copy link

Hi @numanelahi. Thanks for your PR.

I'm waiting for a grpc-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@numanelahi
Copy link
Contributor Author

/test all

@google-oss-prow
Copy link

@numanelahi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gopkarthik
Copy link

/ok-to-test

@google-oss-prow
Copy link

@gopkarthik: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@numanelahi
Copy link
Contributor Author

/test all

@google-oss-prow
Copy link

@numanelahi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gopkarthik
Copy link

/ok-to-test

@google-oss-prow
Copy link

@gopkarthik: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@numanelahi
Copy link
Contributor Author

/test all

@google-oss-prow
Copy link

@gopkarthik: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gopkarthik
Copy link

/ok-to-test

@google-oss-prow
Copy link

@gopkarthik: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gopkarthik
Copy link

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gopkarthik, numanelahi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numanelahi numanelahi merged commit 854b39a into grpc-ecosystem:master May 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants