Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compileOnly for grpc-inprocess/implementation for grpc-netty-shaded #1072

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

panchenko
Copy link

  • The grpc-inprocess module exists mostly for testing purposes, we don't need it at runtime.
  • The classes inside grpc-netty-shaded are repackaged, users are not supposed to access those internal packages, so implementation is enough

@panchenko
Copy link
Author

@shalk Thanks for the feedback, I will check the client more and might be split the change into multiple PRs to simplify the discussion.
Actually my main interest is the server, it works with grpc-inprocess excluded via gradle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants