feat: Allow annotation GrpcClient for target type 'annotation' #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
requested changes
Nov 18, 2023
313hemant313
force-pushed
the
target_annotation_grpcclient
branch
from
8cc7a55 to
c9fa66a
Compare
|
@ST-DDT Test case added, please review. |
ST-DDT
reviewed
Nov 18, 2023
...nfigure/src/main/java/net/devh/boot/grpc/client/inject/metaannotation/GrpcClientWrapper.java
Outdated
Show resolved
Hide resolved
313hemant313
force-pushed
the
target_annotation_grpcclient
branch
from
61e16d3 to
f7fcc9e
Compare
|
CI is red. |
313hemant313
force-pushed
the
target_annotation_grpcclient
branch
from
6b29f73 to
c60a73d
Compare
|
Updated after ./gradlew :tests:spotlessApply. please run the job. |
|
Please pull and run the |
313hemant313
force-pushed
the
target_annotation_grpcclient
branch
from
3db496d to
8a2ab2c
Compare
|
./gradlew check and spotlessApply are success now. |
313hemant313
force-pushed
the
target_annotation_grpcclient
branch
2 times, most recently
from
507416e to
bd2be4b
Compare
Add testcases with usage of GrpcClientWrapper meta-annotation.
313hemant313
force-pushed
the
target_annotation_grpcclient
branch
from
bd2be4b to
e321464
Compare
|
I was using java 19 version. changed it to 17 and pushed a new change with ./gradlew :tests:spotlessApply |
ST-DDT
approved these changes
Nov 19, 2023
How to get this merged ? |
You cannot merge this. We will have another reviewer look at this and then merge it. |
yidongnan
approved these changes
Nov 20, 2023
|
@ST-DDT / @yidongnan When will this change be in new maven release ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow annotation GrpcClient for target type 'annotation'. #991