Introduce a 15s RPC deadline to all calls #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
approved these changes
Feb 1, 2022
lidizheng
approved these changes
Feb 1, 2022
|
Thanks for having a look at this so quickly! 😄 |
|
Done. The binaries will be uploaded shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's good practice to add deadlines to all RPCs and in some cases a server may even enforce that deadlines are present.
Similarly to the connection timeout of 5s already present in
grpcdebug, this change adds a 15s deadline to all RPCs as well.Making the deadline configurable probably isn't needed since 15s should be sufficient in most/all cases.
This change also adds the xDS resolver and upgrades some dependencies.