-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use === in generated code #14
Conversation
Using === is recommended in modern JavaScript / TypeScript since it also verifies for typing without any implicit conversions
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@atreya2011 @lyonlai Could I ask you for a review? |
sure that seems reasonable. I think you will need to sign the google-cla before contributing to the project. @abatilo |
nvm about the google-cla. looks like you've done that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pick. not sure how this is missed.
@abatilo found that there's an extra trigger google cla commit. didn't notice the extra commit but I've fixed it in master. if you run into problem with it just re-pull the master. it is understandable but also if next time you could at your branch, just |
That makes sense, thank you very much for the tip! That'll save me from the empty commits in the future! |
Using === is recommended in modern JavaScript / TypeScript since it also
verifies for typing without any implicit conversions