Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use === in generated code #14

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Use === in generated code #14

merged 2 commits into from
Apr 29, 2021

Conversation

abatilo
Copy link
Contributor

@abatilo abatilo commented Apr 28, 2021

Using === is recommended in modern JavaScript / TypeScript since it also
verifies for typing without any implicit conversions

Using === is recommended in modern JavaScript / TypeScript since it also
verifies for typing without any implicit conversions
@google-cla
Copy link

google-cla bot commented Apr 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@abatilo
Copy link
Contributor Author

abatilo commented Apr 28, 2021

@atreya2011 @lyonlai Could I ask you for a review?

@lyonlai
Copy link
Collaborator

lyonlai commented Apr 28, 2021

sure that seems reasonable. I think you will need to sign the google-cla before contributing to the project. @abatilo

@lyonlai
Copy link
Collaborator

lyonlai commented Apr 28, 2021

nvm about the google-cla. looks like you've done that.

Copy link
Collaborator

@lyonlai lyonlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pick. not sure how this is missed.

@lyonlai lyonlai merged commit 8e54125 into grpc-ecosystem:master Apr 29, 2021
@atreya2011
Copy link
Contributor

@abatilo Hey, sorry for the delay. I am not the maintainer and rather a contributor to this project so @lyonlai is the right person to ask for a review. And it seems like this PR is already merged 🎉

lyonlai added a commit that referenced this pull request Apr 29, 2021
Use === in generated code
@lyonlai
Copy link
Collaborator

lyonlai commented Apr 29, 2021

@abatilo found that there's an extra trigger google cla commit. didn't notice the extra commit but I've fixed it in master. if you run into problem with it just re-pull the master.

it is understandable but also if next time you could at your branch, just git commit --amend -C HEAD and do a force push to the branch it should retrigger the check.

@abatilo
Copy link
Contributor Author

abatilo commented Apr 29, 2021

That makes sense, thank you very much for the tip! That'll save me from the empty commits in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants