Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Error Handling for Server #588

Merged
merged 7 commits into from
Dec 1, 2022
Merged

Custom Error Handling for Server #588

merged 7 commits into from
Dec 1, 2022

Conversation

bgetsug
Copy link
Contributor

@bgetsug bgetsug commented Nov 25, 2022

This picks up where #520 left off and resolves #51.

My particular use case is needing to log (with stack traces) gRPC errors as they occur on the server, such as those having to do with deserialization.

cc: @mraleph

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 25, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

…o Server.create

updated examples, tests, and interop to use new Server.create constructor
misc. code style/formatting tweaks
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 28, 2022
@bgetsug bgetsug requested a review from mraleph November 28, 2022 17:39
Copy link
Member

@mraleph mraleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two final comments - and then I will merge. Thanks a bunch for pushing this through.

lib/src/server/server.dart Outdated Show resolved Hide resolved
lib/src/server/handler.dart Outdated Show resolved Hide resolved
@bgetsug bgetsug requested a review from mraleph November 30, 2022 15:29
@mraleph mraleph merged commit 6c0829e into grpc:master Dec 1, 2022
@long1eu
Copy link

long1eu commented Feb 16, 2023

Can we have this on pub.dev?

@Pingear
Copy link

Pingear commented Jun 19, 2023

Hello !
where can I find documentation on the new logging functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logger for debugging
4 participants