Add IReadOnlyDictionary to BalancerAttributes collection #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
reviewed
May 12, 2023
| @@ -29,7 +30,7 @@ namespace Grpc.Net.Client.Balancer; | |||
| /// Note: Experimental API that can change or be removed without any prior notice. | |||
| /// </para> | |||
| /// </summary> | |||
| public sealed class BalancerAttributes : IDictionary<string, object?> | |||
| public sealed class BalancerAttributes : IDictionary<string, object?>, IReadOnlyDictionary<string, object?> | |||
There was a problem hiding this comment.
Assuming we don't need an API review for adding this interface.
mitchdenny
approved these changes
May 12, 2023
|
This type is basically a copy of |
mitchdenny
approved these changes
May 15, 2023
amcasey
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this collection feel a little more idiomatic to use. Some extension methods in .NET hang off the readonly interface and assume all dictionaries implements IDictionary and IReadOnlyDictionary.