Fix capturing ExecutionContext by timers and background tasks #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
May 16, 2023
| restoreFlow = true; | ||
| } | ||
|
|
||
| _ = Task.Run(ConnectTransportAsync); |
There was a problem hiding this comment.
An alternative would be to put an await Task.Yield() at the top of ConnectTransportAsync, or to leave it as-is.
This is fine, too.
ReubenBond
approved these changes
May 16, 2023
JamesNK
force-pushed
the
jamesnk/executioncontext
branch
from
9bd6377
to
04d62dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturing
ExecutionContextcan cause a memory leak of async locals values.