Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grpc-dotnet debugging #2192

Merged
merged 5 commits into from
Jul 16, 2023
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 16, 2023

This PR significantly improves the debugging experience of gRPC calls. Changes have been applied in many places. There are before and after screenshots of each.

ServerCallContext

Before:

image

After:

image

Server StreamReader

Before:

image

After:

image

Server StreamWriter

Before:

image

After:

image

Client call

Before:

After:

image

Client StreamReader

Before:

image

After:

image

Client StreamWriter

Before:

image

After:

image

Metadata

Before:

image

After:

image

Copy link
Contributor

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore previous comments: you'd already done what I suggested, I just misread the code

@JamesNK JamesNK merged commit 85f3439 into grpc:master Jul 16, 2023
@JamesNK JamesNK deleted the jamesnk/debugging branch July 16, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants