Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request and channel to call debugging #2271

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 5, 2023

This adds the channel and request (for unary and server streaming calls) to gRPC debugging.

This change is tricky because types are split across projects and don't have access to each other's internal views. The hack workaround is to use IEnumerable to return values. Nothing bad is exposed to the user and if another channel implementation doesn't implement enumerable and return values with the expected keys then the debugging information is just missing.

image

@JamesNK JamesNK merged commit 246c43d into grpc:master Sep 6, 2023
2 checks passed
@JamesNK JamesNK deleted the jamesnk/call-debugging-improvement branch September 6, 2023 02:27
oguzhand95 referenced this pull request in cerbos/cerbos-sdk-net Oct 25, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [Grpc.Net.Client](https://togithub.com/grpc/grpc-dotnet) | `2.57.0` ->
`2.58.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Grpc.Net.Client/2.58.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Grpc.Net.Client/2.58.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Grpc.Net.Client/2.57.0/2.58.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Grpc.Net.Client/2.57.0/2.58.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary>

###
[`v2.58.0`](https://togithub.com/grpc/grpc-dotnet/releases/tag/v2.58.0)

#### What's Changed

- Start 2.58 development cycle. by
[@&#8203;jtattermusch](https://togithub.com/jtattermusch) in
[https://github.com/grpc/grpc-dotnet/pull/2267](https://togithub.com/grpc/grpc-dotnet/pull/2267)
- Update ServiceBinderBase.AddMethod annotations to allow null handler
by [@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2270](https://togithub.com/grpc/grpc-dotnet/pull/2270)
- Add request and channel to call debugging by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2271](https://togithub.com/grpc/grpc-dotnet/pull/2271)
- Support disabling load balancing with SocketsHttpHandler.Properties by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2274](https://togithub.com/grpc/grpc-dotnet/pull/2274)
- Remove netstandard1.5 from some projects by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2279](https://togithub.com/grpc/grpc-dotnet/pull/2279)
- Add debugger display to Status by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2281](https://togithub.com/grpc/grpc-dotnet/pull/2281)
- Fix detecting inherited WinHttpHandler by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2288](https://togithub.com/grpc/grpc-dotnet/pull/2288)
- Dispose socket after connection failure by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2287](https://togithub.com/grpc/grpc-dotnet/pull/2287)
- Bump GrpcToolsPackageVersion to 2.58.0 by
[@&#8203;apolcyn](https://togithub.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2290](https://togithub.com/grpc/grpc-dotnet/pull/2290)
- Bump version to pre1 on 2.58 branch by
[@&#8203;apolcyn](https://togithub.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2291](https://togithub.com/grpc/grpc-dotnet/pull/2291)
- Update v2.58.x branch to 2.58.0 by
[@&#8203;apolcyn](https://togithub.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2299](https://togithub.com/grpc/grpc-dotnet/pull/2299)

**Full Changelog**:
grpc/grpc-dotnet@v2.57.0...v2.58.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos-sdk-net).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants