Remove netstandard1.5 from some projects #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
approved these changes
Sep 20, 2023
|
LGTM once my concern from #2278 (comment) is addressed. |
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| <IsGrpcPublishedPackage>true</IsGrpcPublishedPackage> | |||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
| <TargetFrameworks>net462;netstandard1.5;netstandard2.0;netstandard2.1</TargetFrameworks> | |||
| <TargetFrameworks>net462;netstandard2.0;netstandard2.1</TargetFrameworks> | |||
There was a problem hiding this comment.
FYI, netstandard2.1 isn't listed in the recommended list of frameworks in #2278 (which makes this PR only a partial fix), so I'm not sure if not updating it was intentional or not.
There was a problem hiding this comment.
That may just be my fault when reporting the issue. I'm personally okay with it supporting netstandard2.1 as well, as that doesn't add any burden on dependencies (which need to support netstandard2.0 anyway).
|
@jtattermusch Approve please |
jtattermusch
approved these changes
Sep 21, 2023
oguzhand95
referenced
this pull request
in cerbos/cerbos-sdk-net
Oct 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Grpc.Net.Client](https://togithub.com/grpc/grpc-dotnet) | `2.57.0` -> `2.58.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary> ### [`v2.58.0`](https://togithub.com/grpc/grpc-dotnet/releases/tag/v2.58.0) #### What's Changed - Start 2.58 development cycle. by [@​jtattermusch](https://togithub.com/jtattermusch) in [https://github.com/grpc/grpc-dotnet/pull/2267](https://togithub.com/grpc/grpc-dotnet/pull/2267) - Update ServiceBinderBase.AddMethod annotations to allow null handler by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2270](https://togithub.com/grpc/grpc-dotnet/pull/2270) - Add request and channel to call debugging by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2271](https://togithub.com/grpc/grpc-dotnet/pull/2271) - Support disabling load balancing with SocketsHttpHandler.Properties by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2274](https://togithub.com/grpc/grpc-dotnet/pull/2274) - Remove netstandard1.5 from some projects by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2279](https://togithub.com/grpc/grpc-dotnet/pull/2279) - Add debugger display to Status by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2281](https://togithub.com/grpc/grpc-dotnet/pull/2281) - Fix detecting inherited WinHttpHandler by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2288](https://togithub.com/grpc/grpc-dotnet/pull/2288) - Dispose socket after connection failure by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2287](https://togithub.com/grpc/grpc-dotnet/pull/2287) - Bump GrpcToolsPackageVersion to 2.58.0 by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2290](https://togithub.com/grpc/grpc-dotnet/pull/2290) - Bump version to pre1 on 2.58 branch by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2291](https://togithub.com/grpc/grpc-dotnet/pull/2291) - Update v2.58.x branch to 2.58.0 by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2299](https://togithub.com/grpc/grpc-dotnet/pull/2299) **Full Changelog**: grpc/grpc-dotnet@v2.57.0...v2.58.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-net). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2278
cc @jskeet