-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OS detection error in UWP #2376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
mgravell,
ReubenBond,
BrennanConroy and
amcasey
February 26, 2024 07:44
amcasey
approved these changes
Feb 26, 2024
amcasey
reviewed
Feb 26, 2024
Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
amcasey
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
FYI @tonydnewell an update to OS detection |
oguzhand95
referenced
this pull request
in cerbos/cerbos-sdk-net
Apr 1, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Google.Protobuf](https://togithub.com/protocolbuffers/protobuf) | `3.26.0` -> `3.26.1` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Google.Protobuf/3.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Google.Protobuf/3.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Google.Protobuf/3.26.0/3.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Google.Protobuf/3.26.0/3.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Grpc.Net.Client](https://togithub.com/grpc/grpc-dotnet) | `2.61.0` -> `2.62.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Grpc.Net.Client/2.62.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Grpc.Net.Client/2.62.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Grpc.Net.Client/2.61.0/2.62.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Grpc.Net.Client/2.61.0/2.62.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary> ### [`v2.62.0`](https://togithub.com/grpc/grpc-dotnet/releases/tag/v2.62.0) ##### What's Changed - Set default streams value in grpc-client.yml by [@​sebastienros](https://togithub.com/sebastienros) in [https://github.com/grpc/grpc-dotnet/pull/2379](https://togithub.com/grpc/grpc-dotnet/pull/2379) - Fix OS detection error in UWP by [@​JamesNK](https://togithub.com/JamesNK) in [https://github.com/grpc/grpc-dotnet/pull/2376](https://togithub.com/grpc/grpc-dotnet/pull/2376) - Update Grpc.Tools version to 2.62 by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2382](https://togithub.com/grpc/grpc-dotnet/pull/2382) - Bump v2.62.x to pre1 by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2383](https://togithub.com/grpc/grpc-dotnet/pull/2383) - Bump v2.62.x version for final release by [@​apolcyn](https://togithub.com/apolcyn) in [https://github.com/grpc/grpc-dotnet/pull/2400](https://togithub.com/grpc/grpc-dotnet/pull/2400) **Full Changelog**: grpc/grpc-dotnet@v2.61.0...v2.62.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-net). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2375
RtlGetVersion isn't available in UWP. First check if the app is UWP before calling RtlGetVersion.