Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change functional tests to use dynamic ports #2458

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 6, 2024

Fix flaky tests caused by server port already being in use.

Changes:

  • Functional tests with a gRPC server hosted in Kestrel now use dynamic instead of hardcoded ports
  • Changed in-process server to support reporting resolved ports to tests
  • Updated tests that checked for hardcoded ports to use resolved dynamic ports

@JamesNK JamesNK merged commit 5e6821c into grpc:master Jun 6, 2024
5 checks passed
oguzhand95 referenced this pull request in cerbos/cerbos-sdk-net Jul 22, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [Grpc.Net.Client](https://togithub.com/grpc/grpc-dotnet) | `2.63.0` ->
`2.64.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Grpc.Net.Client/2.64.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Grpc.Net.Client/2.64.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Grpc.Net.Client/2.63.0/2.64.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Grpc.Net.Client/2.63.0/2.64.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary>

###
[`v2.64.0`](https://togithub.com/grpc/grpc-dotnet/releases/tag/v2.64.0)

#### What's Changed

- doc: fix typo by [@&#8203;WeihanLi](https://togithub.com/WeihanLi) in
[https://github.com/grpc/grpc-dotnet/pull/2432](https://togithub.com/grpc/grpc-dotnet/pull/2432)
- doc: fix typo by [@&#8203;WeihanLi](https://togithub.com/WeihanLi) in
[https://github.com/grpc/grpc-dotnet/pull/2431](https://togithub.com/grpc/grpc-dotnet/pull/2431)
- ci: upgrade checkout action version by
[@&#8203;WeihanLi](https://togithub.com/WeihanLi) in
[https://github.com/grpc/grpc-dotnet/pull/2434](https://togithub.com/grpc/grpc-dotnet/pull/2434)
- build: configure rollForward in global.json by
[@&#8203;WeihanLi](https://togithub.com/WeihanLi) in
[https://github.com/grpc/grpc-dotnet/pull/2437](https://togithub.com/grpc/grpc-dotnet/pull/2437)
- Support some HttpClientAction settings and log debug message instead
of an error by [@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2448](https://togithub.com/grpc/grpc-dotnet/pull/2448)
- Assign primary handler before other configuration by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2445](https://togithub.com/grpc/grpc-dotnet/pull/2445)
- Update various package versions by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2453](https://togithub.com/grpc/grpc-dotnet/pull/2453)
- Update Grpc.Tools to 2.64.0 by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2456](https://togithub.com/grpc/grpc-dotnet/pull/2456)
- Change functional tests to use dynamic ports by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2458](https://togithub.com/grpc/grpc-dotnet/pull/2458)
- Add WriteResponseHeadersAsync test by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2452](https://togithub.com/grpc/grpc-dotnet/pull/2452)
- Update repo for .NET 9 by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2457](https://togithub.com/grpc/grpc-dotnet/pull/2457)
- Fix flaky ConnectTimeout_MultipleCalls_AttemptReconnect test by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2460](https://togithub.com/grpc/grpc-dotnet/pull/2460)
- Bump branch version to 2.64.0-pre1 by
[@&#8203;stanley-cheung](https://togithub.com/stanley-cheung) in
[https://github.com/grpc/grpc-dotnet/pull/2471](https://togithub.com/grpc/grpc-dotnet/pull/2471)
- \[2.64.x] Update Native.DetectWindowsVersion() to consider Windows
Server 2019 to be Window Server by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2473](https://togithub.com/grpc/grpc-dotnet/pull/2473)
- Bump version to 2.64.0 by
[@&#8203;stanley-cheung](https://togithub.com/stanley-cheung) in
[https://github.com/grpc/grpc-dotnet/pull/2487](https://togithub.com/grpc/grpc-dotnet/pull/2487)

**Full Changelog**:
grpc/grpc-dotnet@v2.63.0...v2.64.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos-sdk-net).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2NpIiwiYm90cyIsImtpbmQvY2hvcmUiXX0=-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants