-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MapGrpcService overload for ServerServiceDefinition #2535
Closed
aka-nse
wants to merge
1,039
commits into
grpc:master
from
aka-nse:feature/MapGrpcService-with-ServerServiceDefinition
Closed
Adds MapGrpcService overload for ServerServiceDefinition #2535
aka-nse
wants to merge
1,039
commits into
grpc:master
from
aka-nse:feature/MapGrpcService-with-ServerServiceDefinition
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot (#1909) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1911) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1910) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update version to 2.50.0-pre1 (on v2.50.x branch) * Update VersionInfo.cs
…#1957) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1958) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ServerServiceDefinition (#1) * support MapGrpcService with ServerServiceDefinition * support MapGrpcService with ServerServiceDefinition * rename sample solution file * create factory method * remove extra using * fix sample project for ServerServiceDefinition mapping * implement Metadata creation for ServerServiceDefinition * implement unit test for MapGrpcService for ServerServiceDefinition --------- Co-authored-by: aka-nse <nakased.1220@gmail.com>
…ntApp (#2536) Bumps [serve-static](https://github.com/expressjs/serve-static) from 1.14.2 to 1.16.2. - [Release notes](https://github.com/expressjs/serve-static/releases) - [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md) - [Commits](expressjs/serve-static@v1.14.2...v1.16.2) --- updated-dependencies: - dependency-name: serve-static dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2567) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.0. - [Commits](indutny/elliptic@v6.5.7...v6.6.0) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ebWebsite/Tests (#2574) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…er disposal of async resources (#2521)
Co-authored-by: James Newton-King <james@newtonking.com>
…ServerServiceDefinition (#1) * support MapGrpcService with ServerServiceDefinition * support MapGrpcService with ServerServiceDefinition * rename sample solution file * create factory method * remove extra using * fix sample project for ServerServiceDefinition mapping * implement Metadata creation for ServerServiceDefinition * implement unit test for MapGrpcService for ServerServiceDefinition --------- Co-authored-by: aka-nse <nakased.1220@gmail.com>
…ttps://github.com/aka-nse/grpc-dotnet into feature/MapGrpcService-with-ServerServiceDefinition
aka-nse
force-pushed
the
feature/MapGrpcService-with-ServerServiceDefinition
branch
from
December 16, 2024 13:07
4606a64
to
e2789f3
Compare
aka-nse
deleted the
feature/MapGrpcService-with-ServerServiceDefinition
branch
December 16, 2024 13:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
This PR is implement for #2236.
ServerServiceDefinition
is defined in Grpc.Core.Api library, and it was a prefer way to implement gRPC server with Grpc.Core.In current grpc-dotnet, the server should be implemented on Asp.Net web application DI container via
GrpcEndpointRouteBuilderExtensions.MapGrpcService
generic method.The APIs in this proposal bridges legacy way into grpc-dotnet to enable to migrate easier.
Describe the solution you'd like
2 overloads of
GrpcEndpointRouteBuilderExtensions.MapGrpcService
are added:This change enables to map gRPC services via
Grpc.Core.ServerServiceDefinition
, therefore migration from Grpc.Core can be more easier.Changes in this PR
Grpc.Core.Api
Grpc.Core.ServerServiceDefinition.BindService(ServiceBinderBase)
method as public*Grpc.AspNetCore.Server
Microsoft.AspNetCore.Builder.GrpcEndpointRouteBuilderExtensions
classMapGrpcService(this IEndpointRouteBuilder, ServerServiceDefinition)
*MapGrpcService(this IEndpointRouteBuilder, Func<IServiceProvider, ServerServiceDefinition>)
*ServerCallHandlerFactory
andServiceRouteBuilder
(non-generic) onMicrosoft.Extensions.DependencyInjection.AddServiceOptions
method**Grpc.AspNetCore.Server.Internal.EndpointServiceBinder
to bind methods inServerServiceDefinition
into ASP.Net core web application server*Grpc.AspNetCore.Server.Internal.ServerCallHandlerFactory
class*Grpc.AspNetCore.Server.Model.Internal.ServiceRouteBuilder
class*ServerCallHandlerBase
*,UnaryServerCallhandler
*,ServerStreamingServerCallHandler
*,ClientStreamingServerCallHandler
*, andDuplexStreamingServerCallHandler
* classes inGrpc.AspNetCore.Server.Internal.CallHandlers
namespaceServerMethodInvokerBase
*,UnaryServerMethodInvoker
*,ServerStreamingServerMethodInvoker
*,ClientStreamingServerMethodInvoker
*, andDuplexStreamingServerMethodInvoker
* classes inGrpc.Shared.Server
namespaceServerCallHandlerFactory
andServerCallHandlerFactory<TService>
intoIServerCallHandlerFactory
*test
MapGrpcService
examples
Grpc.AspNetCore.Server.Tests.TestObjects.Services.WithAttribute.GreeterWithAttribute.BindService
methodDescribe alternatives you've considered
This commit contains concrete code as far as I can write, but I do not care about these implementations.
I welcome better ways to realize this suggestion.
Additional context
No response