Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client compression #362

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Client compression #362

merged 2 commits into from
Jul 8, 2019

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 29, 2019

Fixes #232

@JamesNK JamesNK mentioned this pull request Jul 1, 2019
Closed
10 tasks
@JamesNK
Copy link
Member Author

JamesNK commented Jul 3, 2019

@jtattermusch Please review that this is doing client compression correctly.

@JamesNK JamesNK force-pushed the jamesnk/client-compression branch from bee0b42 to 72420dc Compare July 5, 2019 21:55
jtattermusch
jtattermusch approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments.

@JamesNK JamesNK force-pushed the jamesnk/client-compression branch from 72420dc to 706802b Compare July 8, 2019 21:06
@JamesNK JamesNK merged commit d6c8349 into grpc:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client compression
3 participants
@JamesNK @JunTaoLuo @jtattermusch