Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 9, 2019

Fixes #357

@mgravell

@JamesNK JamesNK requested review from JunTaoLuo and jtattermusch July 9, 2019 00:56
@JamesNK JamesNK changed the title Use contextual serializers on server Use contextual serialization Jul 9, 2019
throw new RpcException(CreateUnknownMessageEncodingMessageStatus(grpcEncoding, GrpcProtocolConstants.CompressionProviders.Select(c => c.EncodingName)));
}

#pragma warning disable CS8600 // Converting null literal or possible null value to non-nullable type.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nullable attribute isn't working here for some reason. Will clean it up when bug in compiler is fixed. Only effects designer.

@mgravell
Copy link
Contributor

mgravell commented Jul 9, 2019

Awesome. Sorry for bringing you a few hundred lines of work, but I think it moves things in the right direction. Appreciated!

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Jul 9, 2019

Why are our tests hanging? I'm inclined to to think there's actually something wrong with them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support missing for contextual deserializer/serializer

4 participants