vet: enforce revive linter (#7589)

* enforce revive for issues that are already fixed

scripts/revive.toml

@@ -0,0 +1,35 @@
+# Enabled rules
+[rule.blank-imports]
+[rule.context-as-argument]
+[rule.context-keys-type]
+[rule.dot-imports]
+[rule.errorf]
+[rule.error-return]
+[rule.error-strings]
+[rule.error-naming]
+[rule.increment-decrement]
+[rule.range]
+[rule.receiver-naming]
+[rule.superfluous-else]
+[rule.time-naming]
+[rule.var-naming]
+[rule.unexported-return]
+[rule.unused-parameter]
+[rule.unreachable-code]
+[rule.var-declaration]
+[rule.use-any]
+
+# Disabled rules
+# https://github.com/grpc/grpc-go/issues/7444 to track TODO(s)
+[rule.empty-block]
+ Disabled = true
+[rule.import-shadowing]
+ Disabled = true
+[rule.exported]
+ Disabled = true # TODO: Enable after existing issues are fixed
+[rule.redefines-builtin-id]
+ Disabled = true # TODO: Enable after existing issues are fixed
+[rule.package-comments]
+ Disabled = true # TODO: Enable after existing issues are fixed
+[rule.indent-error-flow]
+ Disabled = true # TODO: Enable after existing issues are fixed

scripts/vet.sh

@@ -176,11 +176,13 @@ XXXXX PleaseIgnoreUnused'
  popd
 done
 
-# Collection of revive linter analysis checks
-REV_OUT="$(mktemp)"
-revive -set_exit_status=1 -exclude "reflection/test/grpc_testing_not_regenerate/" -formatter plain ./... >"${REV_OUT}" || true
-
-# TODO: Remove `|| true` to unskip linter failures once existing issues are fixed.
-(not grep -v "\.pb\.go:" "${REV_OUT}") || true
+# Error for violation of enabled lint rules in config excluding generated code.
+revive \
+ -set_exit_status=1 \
+ -exclude "reflection/test/grpc_testing_not_regenerate/" \
+ -exclude "**/*.pb.go" \
+ -formatter plain \
+ -config "$(dirname "$0")/revive.toml" \
+ ./...
 
 echo SUCCESS