Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc_testing not included in v1.55.0 release #6264

Closed
DGuhr opened this issue May 9, 2023 · 3 comments
Closed

grpc_testing not included in v1.55.0 release #6264

DGuhr opened this issue May 9, 2023 · 3 comments

Comments

@DGuhr
Copy link

DGuhr commented May 9, 2023

Hey 👋 we are using a package that depends on grpc_testing - https://pkg.go.dev/google.golang.org/grpc/test/grpc_testing and after the latest dependency bump to v1.55.0 go mod tidy breaks as the testing package is not included in the latest release. Was that on purpose? If so, what should one use instead?

Context: https://github.com/authzed/grpcutil uses grpc_testing, we use the util in our service.

@zasweq
Copy link
Contributor

zasweq commented May 9, 2023

Hello. We recently deleted the test/grpc_testing repo: #6164, and moved usages to /interop/grpc_testing. So if you want to continue using these test protos, you should point the package to /interop/grpc_testing. For reference, the test/ repository is not really expected to be stable over time, and my team lead mentioned the best practices for tests might just be to declare your own protos to not have a dependency on our interop repo :).

@DGuhr
Copy link
Author

DGuhr commented May 9, 2023

Thanks for the answer @zasweq :)

As I just import the grpcutil package, I cc @vroldanbet and @jzelinskie as receivers for your message, as they're maintaining the grpcutil. FWIW, I tried to exchange the lib here with 1.55.0 testpb "google.golang.org/grpc/interop/grpc_testing", but it seems interop/grpc_testing does not have the PayloadType_UNCOMPRESSABLE anymore, so all in all I guess your suggestion is the right one to go with.

DGuhr added a commit to DGuhr/grpcutil that referenced this issue May 9, 2023
change grpc_testing to point to interop package now, old package not in same palce in 1.55.0

remove Payloadtype_UNCROMPESSABLE as it is not available anymore

allows updating services that import grpcutil to update to grpc v1.55.0

see also: grpc/grpc-go#6264
@zasweq
Copy link
Contributor

zasweq commented May 9, 2023

Oh ok interesting. Sounds good to me. Hope it goes well :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants