-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify testdata to only one dir #1297
Conversation
Thanks for this PR. We definitely want this. Our proposal is:
What do you think? |
Nit/bikeshedding: how about Path()?
Note: prefer filepath.Join() to manual concatenation for cross-platform compatibility. |
OK, I prefer So, the PR have changed the follow points:
|
ebe3a48
to
84158ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
LGTM.
Unify test data to one dir:
testdata
.