Fix host string passed to PerRPCCredentials #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callHdr.Host already contains the port. So the behavior is broken that: - when default port 443 is used, the audience string still contains a port - when non-default port is used, the port number appears twice in the audience string
menghanl
reviewed
Aug 10, 2017
transport/http2_client.go
Outdated
| pos := strings.LastIndex(callHdr.Method, "/") | ||
| if pos == -1 { | ||
| pos = len(callHdr.Method) | ||
| } | ||
| audience = "https://" + callHdr.Host + port + callHdr.Method[:pos] | ||
| audience = "https://" + host + callHdr.Method[:pos] |
There was a problem hiding this comment.
Can you remove the trailing space? It's causing gofmt failures.
menghanl
approved these changes
Aug 11, 2017
|
Can you please run |
|
Ping -- could you please update this so that Travis passes (gofmt/goimports)? Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callHdr.Host already contains the port. So the behavior is broken that: