Update ServerInHandle comments #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Aug 11, 2017
tap/tap.go
Outdated
| // ServerInHandle defines the function which runs before a new stream is created | ||
| // on the server side. If it returns a non-nil error, the stream will not be | ||
| // created and a RST_STREAM will be sent back to the client with REFUSED_STREAM. | ||
| // The client will receive a RPC error "code = Unavailable, desc = stream |
tap/tap.go
Outdated
| // terminated by RST_STREAM with error code: REFUSED_STREAM". | ||
| // | ||
| // It's intended to be used in situations where you don't want to waste the | ||
| // resource to accept the new stream (e.g. rate-limiting). And the content of |
tap/tap.go
Outdated
| // Note that it is executed in the per-connection I/O goroutine(s) instead of | ||
| // per-RPC goroutine. Therefore, users should NOT have any | ||
| // blocking/time-consuming work in this handle. Otherwise all the RPCs would | ||
| // slow down. |
There was a problem hiding this comment.
Should we add a note about how that means it also won't be called multiple times at once, and so doesn't need to be thread-safe?
menghanl
force-pushed
the
intap_comment
branch
from
f4289cf
to
8b411fd
Compare
menghanl
force-pushed
the
intap_comment
branch
from
8b411fd
to
1747f34
Compare
|
Thanks for the review. All fixed. PTAL. |
dfawley
approved these changes
Aug 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1436