interop: add test case for "pick_first" #2762
Conversation
interop/client/client.go
Outdated
| @@ -270,6 +271,9 @@ func main() { | |||
| case "unimplemented_service": | |||
| interop.DoUnimplementedService(testpb.NewUnimplementedServiceClient(conn)) | |||
| grpclog.Infoln("UnimplementedService done") | |||
| case "pick_first_unary": | |||
| interop.DoPickFirstUnary(tc, 100) | |||
There was a problem hiding this comment.
small nit: might be better to unparameterize rpcCount and hardcode 100 directly into the body of DoPickFirstUnary - that, or make have it fully configurable via command arg.
There was a problem hiding this comment.
I will go with hardcode now. Adding a flag only for one test case also seems bad...
interop/test_utils.go
Outdated
| } | ||
|
|
||
| // NewTestServer creates a test server for test service. | ||
| func NewTestServer() testpb.TestServiceServer { | ||
| return &testServer{} | ||
| return &testServer{ |
There was a problem hiding this comment.
It's not strictly necessary that the Go server implement this test case just yet, since there is a special interop server that's configured with the TXT record etc. which the client will run against. But no problem having it - up to you
There was a problem hiding this comment.
I will revert it for now. It adds a uuid dependency to gRPC.
interop/test_utils.go
Outdated
| continue | ||
| } | ||
| if serverID != id { | ||
| grpclog.Fatalf("got different server ids: %q vs %q", serverID, id) |
There was a problem hiding this comment.
nit: also log the iteration that it failed on?
menghanl
force-pushed
the
interop_serverid
branch
from
417d1e2 to
f49aa0f
Compare
Verify that all requests are sent to the same server.