channelz: wait for clean up before next test #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
May 1, 2019
internal/channelz/funcs.go
Outdated
| @@ -107,6 +112,23 @@ func NewChannelzStorage() { | |||
| subChannels: make(map[int64]*subChannel), | |||
| }) | |||
| idGen.reset() | |||
| return func() { | |||
There was a problem hiding this comment.
It feel weird to have the cleanup function returned when it's not a closure.
channelz is an internal package. It should be OK to add an exported function which blocks until storage is empty.
Also, the function needs a timeout (a const should be good enough).
lyuxuan
force-pushed
the
fixchannelzrace
branch
2 times, most recently
from
c546be4 to
2b07726
Compare
menghanl
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.