Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiling: Fix a data race in the circular buffer. #3254

Merged
merged 2 commits into from
Dec 13, 2019
Merged

profiling: Fix a data race in the circular buffer. #3254

merged 2 commits into from
Dec 13, 2019

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Dec 13, 2019

Also fix linter errors.

@easwars easwars requested a review from dfawley December 13, 2019 17:33
@easwars easwars added this to the 1.26 Release milestone Dec 13, 2019
dfawley
dfawley approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's check with @adtac before submitting.

internal/profiling/buffer/buffer.go Outdated Show resolved Hide resolved
@dfawley dfawley removed this from the 1.26 Release milestone Dec 13, 2019
@dfawley
Copy link
Member

dfawley commented Dec 13, 2019

(No release notes since we didn't do a release with profiling (which would also be internal anyway).)

@adtac
Copy link
Contributor

adtac commented Dec 13, 2019

LGTM 👍

@easwars easwars merged commit f7b39d8 into grpc:master Dec 13, 2019
@easwars easwars deleted the buffer_race branch December 18, 2019 17:01
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easwars @dfawley @adtac