Modified tests to use tlogger. #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Jan 30, 2020
dfawley
reviewed
Jan 31, 2020
dfawley
reviewed
Feb 3, 2020
dfawley
reviewed
Feb 5, 2020
internal/grpctest/tlogger.go
Outdated
| logger.errors[re] += n | ||
| } | ||
|
|
||
| // ErrorsLeft checks if expected errors were not encountered. |
There was a problem hiding this comment.
We should make sure the unencountered expectations are reported by name. I think passing the testing.T here and calling t.Errorf() would be easiest; then you can remove the return value and call this EndTest or Cleanup or something.
There was a problem hiding this comment.
Function is changed to EndTest() and it reports the unmatched error regular expressions by name now.
dfawley
approved these changes
Feb 6, 2020
internal/grpctest/tlogger_test.go
Outdated
| TLogger.ExpectError("Expected error") | ||
| TLogger.ExpectError("Expected ln error") | ||
| TLogger.ExpectError("Expected formatted error") | ||
| TLogger.ExpectErrorN("Expected repeated error", 10) |
There was a problem hiding this comment.
Fixed this.
internal/grpctest/tlogger_test.go
Outdated
| splitFuncName := strings.Split(runtime.FuncForPC(reflect.ValueOf(testFunc).Pointer()).Name(), ".") | ||
| t.Run(splitFuncName[len(splitFuncName)-1], testFunc) | ||
| func (s) TestError(t *testing.T) { | ||
| numErrors := 10 |
There was a problem hiding this comment.
Fixed this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified most tests to use tlogger and leak checker from grpctest.
Updates #3006