xds: handle errors in xds_client #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
reviewed
Jun 2, 2020
| } | ||
| } | ||
| // When LDS resource is removed, we don't delete corresponding RDS cached | ||
| // data. The RDS watch will be canceled, and cache is removed when the last |
|
|
||
| // TODO: remove item from cache and remove corresponding RDS cached data. | ||
| for name := range c.ldsCache { | ||
| if _, ok := d[name]; !ok { |
There was a problem hiding this comment.
Can we have a better variable name for d whose scope has now gotten bigger.
| } | ||
| } | ||
| // When CDS resource is removed, we don't delete corresponding EDS cached | ||
| // data. The EDS watch will be canceled, and cache is removed when the last |
There was a problem hiding this comment.
Ditto here.
s/cache/cache entry/
And better name for d.
menghanl
commented
Jun 3, 2020
|
|
||
| // TODO: remove item from cache and remove corresponding RDS cached data. | ||
| for name := range c.ldsCache { | ||
| if _, ok := d[name]; !ok { |
| } | ||
| } | ||
| // When LDS resource is removed, we don't delete corresponding RDS cached | ||
| // data. The RDS watch will be canceled, and cache is removed when the last |
| } | ||
| } | ||
| // When CDS resource is removed, we don't delete corresponding EDS cached | ||
| // data. The EDS watch will be canceled, and cache is removed when the last |
easwars
approved these changes
Jun 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xds_client
test update because it was expecting no update when resource is removed
test cleanup to apply timeout to channels