Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version to 1.32.0 #3844

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

menghanl
Copy link
Contributor

No description provided.

[skip ci] Skipping Travis. Version number change only
@mvrhov
Copy link

mvrhov commented Aug 26, 2020

Before releasing a 1.32, for real please fix the stuttering that is now present...

#3828 now seems to generate the structs (and also other functions dealing with that service) with stutter...

service ContractService {...}

generates

type ContractServiceService struct {...}

Suffixing with Server before was better, also because the client part has a Client suffix.

IMHO this should be fixed before releasing 1.32.0

@dfawley
Copy link
Member

dfawley commented Aug 26, 2020

Before releasing a 1.32, for real please fix the stuttering that is now present...

As mentioned here, protoc-gen-go-grpc is in its own module and will be v0 (unstable) until we officially release it (as v1.0). It is not considered part of this release.

@mvrhov
Copy link

mvrhov commented Aug 27, 2020

Yeah. Thanks for responding so quickly. I didn't want for this to be forgotten in case you thought that this is important. Sorry for spamming you by adding this into two tickets.

@GarrettGutierrez1 GarrettGutierrez1 merged commit 5e8f833 into grpc:v1.32.x Sep 8, 2020
@menghanl menghanl deleted the release_version_1.32.0 branch September 8, 2020 23:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants