Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-go-grpc: export grpc.ServiceDesc #4035

Merged
merged 2 commits into from
Nov 23, 2020
Merged

protoc-gen-go-grpc: export grpc.ServiceDesc #4035

merged 2 commits into from
Nov 23, 2020

Conversation

resec
Copy link
Contributor

@resec resec commented Nov 13, 2020

Resolve #3762.

  • Exported the ServiceDesc, (e.g. FooService_ServiceDesc)
  • The _serviceDesc is changed to _ServiceDesc because grpc.ServiceDesc is public.
  • Added the disclaimer about the exported field. The content is mainly copied from the issue.

Thanks.

@menghanl menghanl requested a review from dfawley November 19, 2020 21:16
@dfawley dfawley added no release notes Type: Feature New features or improvements in behavior labels Nov 23, 2020
@dfawley dfawley closed this Nov 23, 2020
@dfawley dfawley reopened this Nov 23, 2020
@dfawley
Copy link
Member

dfawley commented Nov 23, 2020

Thanks for the contribution!

@dfawley dfawley merged commit 8f3cc6c into grpc:master Nov 23, 2020
@marcellanz marcellanz mentioned this pull request Dec 6, 2020
Open
davidkhala pushed a commit to Hyperledger-TWGC/grpc that referenced this pull request Dec 7, 2020
@resec @davidkhala
protoc-gen-go-grpc: export grpc.ServiceDesc (grpc#4035)
f967c2a
@resec resec mentioned this pull request Jan 14, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protoc-gen-go-grpc: export grpc.ServiceDesc
2 participants
@resec @dfawley