xds/bootstrap_config: add a string function to server config #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction to server config This string representation of the server config will be used as map keys, so that xds client can be shared by authorities with the same config. Also exported a field so it can be set by tests.
easwars
reviewed
Dec 1, 2021
| // | ||
| // Note that it covers (almost) all the fields so the string can be used map | ||
| // keys. Except NodeProto because NodeProto isn't used by federation (and this | ||
| // is only used as key in federation). |
There was a problem hiding this comment.
I don't understand the last line the comment:
// Except NodeProto because NodeProto isn't used by federation (and this
// is only used as key in federation)
You are saying it is not used by federation, but is used as a key in federation. Can you please clarify.
menghanl
force-pushed
the
bootstrap_config_export_field
branch
from
fb4c518 to
f74d780
Compare
easwars
approved these changes
Dec 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This string representation of the server config will be used as map
keys, so that xds client can be shared by authorities with the same
config.
Also exported a field so it can be set by tests.
RELEASE NOTES: N/A