xds/google-c2p: validate url for no authorities #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindbr8
added
the
Type: Behavior Change
easwars
reviewed
Nov 2, 2022
arvindbr8
added
Type: Behavior Change
easwars
approved these changes
Nov 2, 2022
| }() | ||
| wantErr := "google-c2p URI scheme does not support authorities" | ||
| if err == nil || !strings.Contains(err.Error(), wantErr) { | ||
| cc.Close() |
There was a problem hiding this comment.
Just realized that we don't need this cc.Close() here since that will be taken care of by the deferred function.
There was a problem hiding this comment.
updating that and merging
easwars
removed
the
Type: Behavior Change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per gRPC DirectPath C2P Resolver doc, The "google-c2p" URI scheme will not support authorities.
This diff will validate that
RELEASE NOTES: