Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ringhash: add logs to surface information about ring creation #5832

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Dec 2, 2022

The newly added logs like this:

ring.go:70 [xds] [ring-hash-lb 0xc000148080] newRing: number of subConns is 1, minRingSize is 1024, maxRingSize is 4096  (t=+3.468892ms)
ring.go:74 [xds] [ring-hash-lb 0xc000148080] newRing: normalized subConn weights is [{0xc0001145a0 1}]  (t=+3.485234ms)
ring.go:85 [xds] [ring-hash-lb 0xc000148080] newRing: creating new ring of size 1024  (t=+3.497625ms)

Fixes #5781

RELEASE NOTES: none

@easwars easwars requested a review from dfawley December 2, 2022 00:33
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Dec 2, 2022
@easwars easwars added this to the 1.52 Release milestone Dec 2, 2022
@dfawley dfawley assigned easwars and unassigned dfawley Dec 6, 2022
@easwars easwars merged commit 1949035 into grpc:master Dec 6, 2022
@easwars easwars deleted the ringhash_logs branch December 6, 2022 19:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ringhash: add more logs to show internal details
2 participants