-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/grpcsync: move CallbackSerializer from xdsclient/internal to here #6153
internal/grpcsync: move CallbackSerializer from xdsclient/internal to here #6153
Conversation
@@ -28,11 +28,17 @@ import ( | |||
"github.com/google/go-cmp/cmp" | |||
) | |||
|
|||
const ( | |||
defaultTestWatchExpiryTimeout = 100 * time.Millisecond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this const being anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This const was originally defined in event_test.go
at xdsclient
package and it is used in callback_serializer_test.go
.
Since const values with the same meaning were not defined, I've copied it here and resolved a compile error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no file named event_test.go
in the xdsclient
package. Also, I checked callback_serializer_test.go
and there is no usage of defaultTestWatchExpiryTimeout
. Can you please delete it. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test entry point like the following is defined in event_test.go
in the grpcsync
package.
So callback_serializer_test.go
depends on event_test.go
. Should I revise this file name or do anything else?
type s struct {
grpctest.Tester
}
func Test(t *testing.T) {
grpctest.RunSubTests(t, s{})
}
Also, I didn't notice that there is no usage of defaultTestWatchExpiryTimeout
. I've deleted this definition from callback_serializer_test.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I didn't notice that there is no usage of defaultTestWatchExpiryTimeout. I've deleted this definition from callback_serializer_test.go.
Yes, that's all I wanted. Thanks.
Again, one test pipeline failed. A test time out seems to cause this fail.
May it be a flaky test? |
This is a known flake: #6075 |
Move CallbackSerializer from xdsclient/internal to grpcsync package
Please refer to this conversation in #6036 .
RELEASE NOTES: none