Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: add error_handling example; move errors to error_details #6293

Merged
merged 3 commits into from
May 17, 2023
Merged

examples: add error_handling example; move errors to error_details #6293

merged 3 commits into from
May 17, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented May 17, 2023

RELEASE NOTES: none

@dfawley dfawley added the Type: Documentation Documentation or examples label May 17, 2023
@dfawley dfawley added this to the 1.56 Release milestone May 17, 2023
arvindbr8
arvindbr8 requested changes May 17, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this; else we would be losing to gRPC-Java in the great examples races.

Very minor comments. PTAL

examples/features/error_handling/client/main.go Outdated
@@ -0,0 +1,70 @@
/*
*
* Copyright 2018 gRPC authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to the future 🔁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pitfalls of cp -R I guess.

examples/features/error_handling/server/main.go Outdated
@@ -0,0 +1,65 @@
/*
*
* Copyright 2018 gRPC authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to the future 2 🔁

examples/features/error_handling/README.md Show resolved Hide resolved
examples/features/error_handling/server/main.go Outdated Show resolved Hide resolved
dfawley and others added 2 commits May 17, 2023 13:54
@dfawley @arvindbr8
Update examples/features/error_handling/server/main.go
fd16269 
Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
@dfawley
copyright
3f3a34c
@dfawley
Copy link
Member Author

dfawley commented May 17, 2023

Updated; PTAL

@dfawley dfawley assigned arvindbr8 and unassigned dfawley May 17, 2023
@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 May 17, 2023
@dfawley dfawley merged commit 417d4b6 into grpc:master May 17, 2023
1 check passed
@dfawley dfawley deleted the examples branch May 17, 2023 22:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.56 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @arvindbr8