client: encode the authority by default #6318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Jun 6, 2023
dfawley
changed the title
zasweq
added a commit
to zasweq/grpc-go
that referenced
this pull request
Jun 9, 2023
This reverts commit 68576b3.
zasweq
added a commit
that referenced
this pull request
Jun 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the endpoint is returned as the authority unless it can be determined by the scheme or from the dial or credentials. In case the endpoint has multiple slashes, this can be invalid. To handle this use case encode the authority by default.
In the future this can be subsumed by adding per resolver builder method that can provide a more sophisticated logic for determining authority.
@dfawley
(FYI: this PR was rolled back before any release)
RELEASE NOTES: none