benchmark: Add support for Poisson load in benchmark client #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test |
gnossen
reviewed
Jun 16, 2023
|
Discussed offline, the conclusion was to merge this, and then get the gRPC Eng Prod team to add Go to PSM Benchmarks, than manually verify using kokoro logs displayed (given (and thus expected) qps and the actually received qps. |
arvindbr8
reviewed
Jun 21, 2023
benchmark/worker/benchmark_client.go
Outdated
| // getStats returns the stats for benchmark client. | ||
| // It resets lastResetTime and all histograms if argument reset is true. | ||
| func (bc *benchmarkClient) getStats(reset bool) *testpb.ClientStats { | ||
| func (bc *benchmarkClient) getStats(reset bool) *testpb.ClientStats { // can you get QPS out of this, maybe in metric key value pair somehow. Or poll every x time and see how many requests... |
arvindbr8
approved these changes
Jun 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Poisson Load in the benchmark client. This is needed to put gRPC-Go on the xDS benchmarking dashboard.
RELEASE NOTES: