Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSM interop] Don't fail target if sub-target already failed (v1.54.x backport) #6397

Merged

[PSM interop] Don't fail target if sub-target already failed (#6390)

2aa3a27
Select commit
Loading
Failed to load commit list.
Merged

[PSM interop] Don't fail target if sub-target already failed (v1.54.x backport) #6397

[PSM interop] Don't fail target if sub-target already failed (#6390)
2aa3a27
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Dec 21, 2023 in 3s

2/3 Fail(s): LABEL, MILESTONE

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    1 PASSED
    2 FAILED

Details

❌ Validator: LABEL

  • label does not include "^Type:"
    Input :
    Settings : {"must_include":{"regex":"^Type:"}}

✔️ Validator: DESCRIPTION

  • ✔️ description must include '^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$'**
    Input : Backport of #6390 to v1.54.x.

We don't want file multiple bugs if any of the sub-tests of the url_map test fails.

The same change in core: grpc/grpc#33520.

RELEASE NOTES: N/A
Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}

❌ Validator: MILESTONE

  • milestone does not include "Release$"
    Input :
    Settings : {"must_include":{"regex":"Release$"}}