Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflection: rename proto imports for disambiguation in import script #6411

Merged
merged 1 commit into from
Jun 26, 2023
Merged

reflection: rename proto imports for disambiguation in import script #6411

merged 1 commit into from
Jun 26, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jun 26, 2023

The current import renames v1grpc, v1pb, v1alphagrpc and v1alphapb are not distinct enough and can cause trouble in the copybara import script. This change disambiguates them.

RELEASE NOTES: none

@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jun 26, 2023
@easwars easwars added this to the 1.57 Release milestone Jun 26, 2023
zasweq
zasweq approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@easwars easwars merged commit 789cf4e into grpc:master Jun 26, 2023
1 check passed
@easwars easwars deleted the reflection_proto_import_renaming branch June 26, 2023 18:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees
No one assigned
Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.57 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @zasweq