Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status: fix panic when servers return a wrapped error with status OK (#6374) #6430

Merged
merged 1 commit into from
Jul 6, 2023
Merged

status: fix panic when servers return a wrapped error with status OK (#6374) #6430

merged 1 commit into from
Jul 6, 2023

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Jul 6, 2023

Backport of nil panic fix.

RELEASE NOTES:

  • status: status.FromError now returns an error with codes.Unknown when the error implements the GRPCStatus() method, and calling GRPCStatus() returns nil.

@zasweq zasweq requested a review from dfawley July 6, 2023 18:18
@zasweq zasweq added this to the 1.57 Release milestone Jul 6, 2023
@dfawley dfawley modified the milestones: 1.57 Release, 1.56 Release Jul 6, 2023
@zasweq zasweq merged commit 6b0b291 into grpc:v1.56.x Jul 6, 2023
9 of 10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
1.56 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@zasweq @dfawley @atollena