grpc: report connectivity state changes on the ClientConn for Subscribers #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
requested changes
Jul 18, 2023
|
@easwars : Thank you for reviewing! I've fixed some implementations according to your comments. |
easwars
reviewed
Jul 26, 2023
easwars
changed the title
easwars
reviewed
Jul 27, 2023
easwars
reviewed
Jul 31, 2023
Co-authored-by: Easwar Swaminathan <easwars@google.com>
easwars
approved these changes
Aug 1, 2023
|
@dfawley for second set of eyes. |
dfawley
reviewed
Aug 4, 2023
| ctx, cancel := context.WithTimeout(context.Background(), defaultTestTimeout) | ||
| defer cancel() | ||
| r.UpdateState(resolver.State{Addresses: []resolver.Address{{Addr: backend.Address}}}) | ||
| awaitState(ctx, t, cc, connectivity.Ready) |
There was a problem hiding this comment.
This looks like it will be flaky to me, just like the previous instance of the same thing we found.
However, idleness is a great test of the pubsub delivering transitions reliably that the other API could miss. So I think we can just delete this awaitState and everything will be good.
| if gotState != wantState { | ||
| t.Errorf("Received unexpected state: %q; want: %q", gotState, wantState) | ||
| } | ||
| case <-time.After(defaultTestTimeout): |
There was a problem hiding this comment.
Nit: initialize the context at the start of the test and use <-ctx.Done() here instead.
Comment on lines
109
to
111
| if t.Failed() { | ||
| t.FailNow() | ||
| } |
There was a problem hiding this comment.
IIUC this can be deleted since there is no code after it.
|
Thanks @dfawley ! |
dfawley
approved these changes
Aug 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a logic to report connectivity state changes on the ClientConn for Subscribers.
Please refer to #6036 (comment) in #6036 . Original issue is #5818.
RELEASE NOTES: none