Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/xds: increase default test timeout #6498

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Aug 3, 2023

As part of some other testing, I noticed that one of the custom LB policy tests which verifies RR behavior was quite flaky on google3. The reason being the 5s default test timeout that we use. The test verifies that the RPC distribution reaches expected value within this timeout. Increasing the timeout to 10s fixes the issue.

RELEASE NOTES: none

@easwars easwars requested a review from zasweq August 3, 2023 16:36
@easwars easwars added this to the 1.58 Release milestone Aug 3, 2023
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zasweq zasweq assigned easwars and unassigned zasweq Aug 3, 2023
@easwars easwars merged commit 2db7b17 into grpc:master Aug 3, 2023
1 check passed
@easwars easwars deleted the xds_e2e_test_default_timeout branch August 3, 2023 17:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants