Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: replace RemoveSubConn with Shutdown as much as possible #6505

Merged
merged 2 commits into from
Aug 4, 2023
Merged

all: replace RemoveSubConn with Shutdown as much as possible #6505

merged 2 commits into from
Aug 4, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 4, 2023

This is a cleanup to finish the work started in #6493.

RELEASE NOTES: none

@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Aug 4, 2023
@dfawley dfawley added this to the 1.58 Release milestone Aug 4, 2023
@dfawley dfawley requested a review from arvindbr8 August 4, 2023 16:12
arvindbr8
arvindbr8 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Aug 4, 2023
@dfawley dfawley merged commit 6c0c69e into grpc:master Aug 4, 2023
1 check passed
@dfawley dfawley deleted the RemoveSubConnShutdown branch August 4, 2023 17:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.58 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @arvindbr8