xds/clusterresolver: stop forwarding UpdateSubConnState calls #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
approved these changes
Aug 9, 2023
Comment on lines
405
to
406
| // No need to override opts.StateListener; just forward all calls to the | ||
| // child that created the SubConn. |
There was a problem hiding this comment.
Optional nit: I don't think you need this comment anymore. If we have this comment we'd have to restate this in every balancer since we switched over.
There was a problem hiding this comment.
Yeah, this should have just been deleted entirely since ccWrapper embeds ClientConn. Done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All children use
StateListenerso this is unnecessary now. Also, delete associated test.RELEASE NOTES: none