Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interop/grpc_testing: regenerate protos #6534

Merged
merged 3 commits into from
Aug 10, 2023
Merged

interop/grpc_testing: regenerate protos #6534

merged 3 commits into from
Aug 10, 2023

Conversation

arvindbr8
Copy link
Member

RELEASE NOTES: none

@arvindbr8 arvindbr8 requested a review from dfawley August 9, 2023 23:40
@arvindbr8 arvindbr8 added the Type: Dependencies Updating/adding/removing dependencies label Aug 9, 2023
@arvindbr8 arvindbr8 added this to the 1.58 Release milestone Aug 9, 2023
@arvindbr8
Copy link
Member Author

There is a typo in a recent commit to gRPC-proto which is breaking vet. Posted a PR to fix it grpc/grpc-proto#130

@dfawley
Copy link
Member

dfawley commented Aug 10, 2023

Make sure you're using the right version of protoc and protoc-gen-go. vet.sh has the commands you can use to download and update.

@dfawley dfawley assigned arvindbr8 and unassigned dfawley Aug 10, 2023
@arvindbr8
Copy link
Member Author

Sure on it. also go version on my local is go1.19.1 and github uses go1.20.7.

@dfawley
Copy link
Member

dfawley commented Aug 10, 2023

Your Go version won't affect the output of the proto files, so don't worry about that.

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Aug 10, 2023
@arvindbr8 arvindbr8 changed the title *: regenerate protos interop/grpc_testing: regenerate protos Aug 10, 2023
@arvindbr8 arvindbr8 merged commit 182b0ad into grpc:master Aug 10, 2023
1 check passed
@arvindbr8 arvindbr8 deleted the fix_proto branch September 26, 2023 20:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Milestone
1.58 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@arvindbr8 @dfawley