Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go cipher suites to find TLS suite string name #6709

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Use Go cipher suites to find TLS suite string name #6709

merged 3 commits into from
Oct 10, 2023

Conversation

bcr
Copy link
Contributor

@bcr bcr commented Oct 10, 2023 •
edited by dfawley
Loading

Replaces the map of cipher suite IDs with lookups in the globally known cipher suites. Fixes #5075

RELEASE NOTES: none

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 10, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #6709 (9daa9b2) into master (59f57b1) will increase coverage by 0.13%.
Report is 3 commits behind head on master.
The diff coverage is 54.54%.

Additional details and impacted files

dfawley
dfawley requested changes Oct 10, 2023
View reviewed changes
credentials/tls.go Outdated Show resolved Hide resolved
credentials/tls.go Outdated Show resolved Hide resolved
@dfawley
Copy link
Member

dfawley commented Oct 10, 2023

Thanks for the PR! LGTM except for a couple minor tweaks.

@dfawley dfawley added this to the 1.60 Release milestone Oct 10, 2023
@bcr bcr requested a review from dfawley October 10, 2023 20:42
@dfawley dfawley assigned arvindbr8 and unassigned bcr Oct 10, 2023
@dfawley dfawley requested a review from arvindbr8 October 10, 2023 20:45
@dfawley
Copy link
Member

dfawley commented Oct 10, 2023

@arvindbr8 can you take a second look?

arvindbr8
arvindbr8 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcr
Copy link
Contributor Author

bcr commented Oct 10, 2023

Thanks folks -- I'm good on my end too.

@dfawley dfawley merged commit 32e3ef1 into grpc:master Oct 10, 2023
12 of 13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@arvindbr8 arvindbr8

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.60 Release
Development

Successfully merging this pull request may close these issues.

tls: clarify/cleanup TLS cipher list
3 participants
@bcr @dfawley @arvindbr8