github: modify codecov.yml #6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6720 +/- ##
==========================================
+ Coverage 82.70% 83.39% +0.68%
==========================================
Files 293 285 -8
Lines 31161 30961 -200
==========================================
+ Hits 25773 25821 +48
+ Misses 4332 4070 -262
- Partials 1056 1070 +14 |
easwars
reviewed
Oct 12, 2023
.github/codecov.yml
Outdated
| - "benchmark/" | ||
| - "internal/testutils" | ||
| - "*testutils*" |
There was a problem hiding this comment.
This will be covered by *test* right?
There was a problem hiding this comment.
Also, I'm a little concerned about using wildcards here. How many entries do you have if you were to not use wildcards and instead listed them out explicitly?
There was a problem hiding this comment.
I actually agree with you. I'll make it explicit since its not that big of a list
dfawley
reviewed
Nov 7, 2023
.github/codecov.yml
Outdated
| - "internal/testutils" | ||
| - ".*.pb.go" | ||
| - "benchmark/**/*" | ||
| - "stress/**/*" |
.github/codecov.yml
Outdated
| # All 'pb.go's | ||
| - "**/*.pb.go" | ||
| # Tests and test related files. | ||
| - "test/**/*" |
There was a problem hiding this comment.
**/test instead of anything with test?
Similarly:
**/testutils**/testdata
.github/codecov.yml
Outdated
| - "balancer/rls/internal/test/e2e/**/*" | ||
| - "testdata" | ||
| # Other submodules. | ||
| - "security/**/*" |
dfawley
approved these changes
Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements to codecov settings
diffandfilesto PR comment: https://docs.codecov.com/docs/pull-request-comments#layoutRELEASE NOTES: n/a