Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding: move codec tests out of top-level test package #6728

Merged
merged 2 commits into from
Oct 13, 2023
Merged

encoding: move codec tests out of top-level test package #6728

merged 2 commits into from
Oct 13, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 13, 2023 •
edited
Loading

Summary of changes:

  • Move codec tests out of test package into encoding_test
    • This makes them true e2e style tests
  • Remove custom codec support from the testServer in the our current end2end package

#6727

RELEASE NOTES: none

@easwars easwars added this to the 1.60 Release milestone Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #6728 (c0c4ec0) into master (ddb026e) will increase coverage by 0.42%.
The diff coverage is n/a.

Additional details and impacted files

arvindbr8
arvindbr8 requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one minor comment

encoding/encoding_test.go Outdated Show resolved Hide resolved
encoding/encoding_test.go Show resolved Hide resolved
@easwars easwars closed this Oct 13, 2023
@easwars easwars reopened this Oct 13, 2023
@easwars easwars merged commit df8fc99 into grpc:master Oct 13, 2023
23 checks passed
@easwars easwars deleted the improve_codec_test branch October 13, 2023 20:54
@arvindbr8 arvindbr8 linked an issue Oct 17, 2023 that may be closed by this pull request
Cleanup codec tests #6727
Closed
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Nov 7, 2023
@easwars @arvindbr8
encoding: move codec tests out of top-level test package (grpc#6728)
d4e4963
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@easwars easwars

Labels
Type: Testing
Projects
None yet
Milestone
1.60 Release
Development

Successfully merging this pull request may close these issues.

Cleanup codec tests
2 participants
@easwars @arvindbr8