Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/server: Fix nil panic in xDS Server when received LDS with no inline RDS #6747

Closed
wants to merge 5 commits into from

Responded to Doug's comments

16d7f91
Select commit
Loading
Failed to load commit list.
Closed

xds/server: Fix nil panic in xDS Server when received LDS with no inline RDS #6747

Responded to Doug's comments
16d7f91
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch failed Oct 31, 2023 in 0s

63.63% of diff hit (target 80.00%)

View this Pull Request on Codecov

63.63% of diff hit (target 80.00%)

Annotations

Check warning on line 334 in xds/internal/server/listener_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/internal/server/listener_wrapper.go#L334 

Added line #L334 was not covered by tests

Check warning on line 337 in xds/internal/server/listener_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/internal/server/listener_wrapper.go#L337 

Added line #L337 was not covered by tests

Check warning on line 366 in xds/internal/server/listener_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/internal/server/listener_wrapper.go#L365-L366 

Added lines #L365 - L366 were not covered by tests
View more details on Codecov